Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • compiler
  • translator
  • ASTMetadataHLSL.cpp
Find file
BlameHistoryPermalink
  • Corentin Wallez's avatar
    Fixes for the tagging of discontinuous loops · a1884f2b
    Corentin Wallez authored Apr 29, 2015
    The first fix was for all loops being considered discontinuous in
    OutputHLSL because of a typo that produced a tautology.
    
    The error was not detected by the unit tests because as an optimization we
    do not generate Lod0 calls when they are not needed for the callee
    function (which was correctly detected by the analysis in this case).
    Fixed the unit tests by adding a call to a builtin gradient operation.
    
    The second fix was for discard not being taken into account in the
    analyses of the AST, which caused a WebGL test regression after the first
    fix for conformance/glsl/bugs/conditional-discard-in-loop
    
    BUG=angleproject:982
    
    Change-Id: I1315eac1ad36f726be52d7fda5facf3104341b1f
    Reviewed-on: https://chromium-review.googlesource.com/267814Tested-by: 's avatarCorentin Wallez <cwallez@chromium.org>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
    a1884f2b
ASTMetadataHLSL.cpp 13.7 KB
EditWeb IDE
×

Replace ASTMetadataHLSL.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.