Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • FramebufferAttachment.cpp
Find file
BlameHistoryPermalink
  • Corentin Wallez's avatar
    FramebufferAttachment: do not attach with an uninitialized mResource · 314f9b33
    Corentin Wallez authored Aug 20, 2015
    Otherwise attach will try to call onDetach on mResource, causing an UB
    (and a segfault in most cases).
    
    This fixes a crash when running angle_unittests on Mac with another
    patch.
    
    BUG=angleproject:891
    
    Change-Id: I09d34d7246849059a13bc2fb00a61837cccd97d7
    Reviewed-on: https://chromium-review.googlesource.com/294830Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Tested-by: 's avatarCorentin Wallez <cwallez@chromium.org>
    314f9b33
FramebufferAttachment.cpp 5.03 KB
EditWeb IDE
×

Replace FramebufferAttachment.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.