Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • compiler_tests
  • ShCompile_test.cpp
Find file
BlameHistoryPermalink
  • Olli Etuaho's avatar
    Don't split the file into two chunks in shader_translator · 0304d2fe
    Olli Etuaho authored Sep 07, 2015
    Splitting the file into two strings in shader_translator complicated
    testing line/file numbering related functionality with it, since each
    chunk passed to ShCompile has its own file number and line numbering.
    These are exposed to the preprocessor in __FILE__ and __LINE__ predefined
    macros.
    
    Just supply the file to ShCompile in a single string. Also, since the
    original motivation for splitting the string seems to have been to
    exercise ShCompile with multiple strings, add a new unit test that
    ensures that ShCompile handles multiple strings as expected.
    
    BUG=angleproject:989
    TEST=angle_unittests
    
    Change-Id: I31d24925ec85ca3411e537df25a985f09737403e
    Reviewed-on: https://chromium-review.googlesource.com/297251Tested-by: 's avatarOlli Etuaho <oetuaho@nvidia.com>
    Reviewed-by: 's avatarZhenyao Mo <zmo@chromium.org>
    0304d2fe
ShCompile_test.cpp 2.26 KB
EditWeb IDE
×

Replace ShCompile_test.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.