Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • preprocessor_tests
  • if_test.cpp
Find file
BlameHistoryPermalink
  • Olli Etuaho's avatar
    Don't evaluate short-circuited preprocessor expressions · 809ec546
    Olli Etuaho authored Aug 26, 2015
    Resubmit with clang build issue fixed. The result of a short-circuited
    operation is now either 0 or 1.
    
    ESSL 3.00 spec section 3.4 mentions that the second operand in a logical
    && or || preprocessor operation is evaluated only if the first operand
    doesn't short-circuit the expression. The non-evaluated part of a
    preprocessor expression may also have undefined identifiers.
    
    Make the expression parser follow the spec by ignoring errors that are
    generated inside short-circuited expressions. This includes undefined
    identifiers and divide by zero.
    
    BUG=angleproject:347
    TEST=dEQP-GLES3.functional.shaders.preprocessor.undefined_identifiers.*
         angle_unittests
    
    Change-Id: I4163f96ec46d40ac859ffb39d91b89490041e44d
    Reviewed-on: https://chromium-review.googlesource.com/297252Tested-by: 's avatarOlli Etuaho <oetuaho@nvidia.com>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    809ec546
if_test.cpp 23.7 KB
EditWeb IDE
×

Replace if_test.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.