Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • preprocessor_tests
  • define_test.cpp
Find file
BlameHistoryPermalink
  • Olli Etuaho's avatar
    Fix preprocessor macro replacement list location · e6432c85
    Olli Etuaho authored Sep 08, 2015
    According to the dEQP tests, a macro replacement list generated by a
    function-like macro invocation should get its location from the closing
    parenthesis of the invocation. The tests check this by using __LINE__ in
    a macro with a multi-line invocation. It's not quite clear from the spec
    that the enforced behavior is expected as opposed to the replacement
    list getting its location from the macro name, but a minor correction to
    the preprocessor makes the dEQP tests pass.
    
    Newlines in the preprocessor unit tests are generated according to the
    source locations in the token list produced by the preprocessor, so the
    expectations of a few tests also need to be updated.
    
    BUG=angleproject:989
    TEST=dEQP-GLES3.functional.shaders.preprocessor.predefined_macros.*
         (2 start passing with this change),
         angle_unittests
    
    Change-Id: I4cc9da09bd0985310a05ebf6def680916a46308a
    Reviewed-on: https://chromium-review.googlesource.com/297990Tested-by: 's avatarOlli Etuaho <oetuaho@nvidia.com>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarZhenyao Mo <zmo@chromium.org>
    e6432c85
define_test.cpp 23.8 KB
EditWeb IDE
×

Replace define_test.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.