Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • compiler_tests
  • MalformedShader_test.cpp
Find file
BlameHistoryPermalink
  • Olli Etuaho's avatar
    Fix parsing integers larger than 0x7FFFFFFF · f541f529
    Olli Etuaho authored Oct 13, 2015
    Parsing should accept all values between 0 and 0xFFFFFFFF as specified in
    ESSL 3.00 section 4.1.3.
    
    When a signed literal is parsed, it's interpreted as if it specifies the
    bit pattern of a two's complement integer. For example, parsing
    "0xFFFFFFFF" results in -1. Decimal literals behave the same way, so for
    example parsing "3000000000" results in -1294967296.
    
    This change affects parsing of literals in ESSL 1.00 as well. In ESSL
    3.00, an out-of-range integer literal now generates a compiler error.
    
    Unit tests are added based on examples in the ESSL 3.00 spec and one
    example in GLSL 4.5 spec that ESSL should match.
    
    BUG=541550
    TEST=angle_unittests
    
    Change-Id: I82f8ef5cfa2881019a3f80d77ff99707d61c000d
    Reviewed-on: https://chromium-review.googlesource.com/305420Reviewed-by: 's avatarZhenyao Mo <zmo@chromium.org>
    Tested-by: 's avatarOlli Etuaho <oetuaho@nvidia.com>
    Reviewed-by: 's avatarCorentin Wallez <cwallez@google.com>
    f541f529
MalformedShader_test.cpp 28.6 KB
EditWeb IDE
×

Replace MalformedShader_test.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.