Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • compiler
  • translator
  • SeparateArrayInitialization.h
Find file
BlameHistoryPermalink
  • Olli Etuaho's avatar
    Accept const array initialization in shader parsing · b1edc4f5
    Olli Etuaho authored Nov 02, 2015
    Array constructors are not folded, unlike all other constant expressions.
    Change initializer parsing path so that it accepts constant initializers
    whether they are folded or not.
    
    Some parts need to be adapted to work with expressions that are qualified
    as constant but that are not necessarily folded:
    
    1. Identifier parsing
    2. Indexing parsing
    3. Field selection parsing
    4. HLSL output for variable declarations
    5. Determining unary operator result type
    6. Determining binary operator result type
    7. Determining built-in function call result type
    8. Determining ternary operator result type
    
    Corner cases that are not supported yet:
    
    1. Using array constructors inside case labels
    2. Using array constructors inside array size expressions
    3. Detecting when a negative constant expression containing an array
       constructor is used to index an array
    
    In these cases being able to constant fold the expression is essential to
    validating that the code is correct, so they require a more sophisticated
    solution. For now we keep the old code that rejects the shader if ANGLE
    hasn't been able to constant fold the case label or array size. In case of
    indexing an array with a negative constant expression containing an array
    constructor, ANGLE will simply treat it as a non-constant expression.
    
    BUG=541551
    BUG=angleproject:1094
    TEST=dEQP-GLES3.functional.shaders.constant_expressions.* (all pass),
         angle_unittests
    
    Change-Id: I0cbc47afd1651a4dece3d68acf7ec72a01fdf047
    Reviewed-on: https://chromium-review.googlesource.com/310231Tested-by: 's avatarOlli Etuaho <oetuaho@nvidia.com>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    b1edc4f5
SeparateArrayInitialization.h 911 Bytes
EditWeb IDE
×

Replace SeparateArrayInitialization.h

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.