Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • compiler
  • translator
  • ParseContext.cpp
Find file
BlameHistoryPermalink
  • Olli Etuaho's avatar
    Fix issues in comma operator parsing · 15200047
    Olli Etuaho authored Nov 04, 2015
    Always qualify comma operator result with EvqTemporary in ESSL3, as
    specified.
    
    Also, it is possible that in the future some expressions are qualified
    as EvqConst but they'd still have side effects, in which case discarding
    them when they're the left operand of the comma operator would be wrong.
    This would be the case if ANGLE allowed "(a = b).length()" for example.
    For this reason it is better to check whether the left node has side
    effects, rather than check its const qualification, and only discard it
    if it doesn't.
    
    Also, Intermediate::addComma() never returns null, so there's no need to
    check the result.
    
    BUG=angleproject:1201
    TEST=WebGL conformance tests
         conformance/glsl/misc/sequence-operator-returns-constant.html
         conformance2/glsl3/sequence-operator-returns-non-constant.html
    
    Change-Id: Ibfbd92baa4910b14c0dc8f8a3c3008440d191cd6
    Reviewed-on: https://chromium-review.googlesource.com/311171Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Tryjob-Request: Jamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
    Tested-by: 's avatarOlli Etuaho <oetuaho@nvidia.com>
    15200047
ParseContext.cpp 133 KB
EditWeb IDE
×

Replace ParseContext.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.