Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • compiler_tests
  • ConstantFolding_test.cpp
Find file
BlameHistoryPermalink
  • Olli Etuaho's avatar
    Fix constructor constant folding · 1d122789
    Olli Etuaho authored Nov 06, 2015
    The previous solution for constant folding constructors was significantly
    overengineered and partially incorrect. Switch to a much simpler
    constructor folding function that does not use an AST traverser, but
    simply iterates over the constant folded parameters of the constructor
    and doesn't do any unnecessary checks. It also reuses some code for
    constant folding other built-in functions.
    
    This fixes issues with initializing constant matrices with only a single
    parameter. Instead of copying the first component of the constructor
    parameter all over the matrix, passing a vec4 or matrix argument now
    assigns the values correctly.
    
    BUG=angleproject:1193
    TEST=angle_unittests, WebGL conformance tests
    
    Change-Id: I50b10721ea30cb15843fba892c1b1a211f1d72e5
    Reviewed-on: https://chromium-review.googlesource.com/311191
    Tryjob-Request: Olli Etuaho <oetuaho@nvidia.com>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarZhenyao Mo <zmo@chromium.org>
    Tested-by: 's avatarOlli Etuaho <oetuaho@nvidia.com>
    1d122789
ConstantFolding_test.cpp 22.3 KB
EditWeb IDE
×

Replace ConstantFolding_test.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.