Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • compiler
  • translator
  • BuiltInFunctionEmulatorHLSL.cpp
Find file
BlameHistoryPermalink
  • Olli Etuaho's avatar
    Fix destructing TStrings through BuiltInFunctionEmulator after free · 950457b3
    Olli Etuaho authored May 26, 2015
    BuiltInFunctionEmulator gets destructed after the PoolAllocator has already
    freed memory. That's why BuiltInFunctionEmulator can't hold any objects that
    contain parts stored in the memory pool that would be accessed in its
    destructor. Use only pointers to TType objects inside
    BuiltInFunctionEmulator, so that the BuiltInFunctionEmulator destructor doesn't
    access TStrings which have data in the memory pool.
    
    Also fix style issues in BuiltInFunctionEmulator.
    
    BUG=angleproject:1010
    TEST=dEQP-GLES3.functional.shaders.builtin_functions.*
    
    Change-Id: Ic35caf80bf125d0427c2ed2024e98657756103b6
    Reviewed-on: https://chromium-review.googlesource.com/272738Tested-by: 's avatarOlli Etuaho <oetuaho@nvidia.com>
    Reviewed-by: 's avatarZhenyao Mo <zmo@chromium.org>
    950457b3
BuiltInFunctionEmulatorHLSL.cpp 20.3 KB
EditWeb IDE
×

Replace BuiltInFunctionEmulatorHLSL.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.