Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • samples
  • stencil_operations
  • StencilOperations.cpp
Find file
BlameHistoryPermalink
  • hendrikw's avatar
    angle: prevent huge allocations when GL_MAX_VERTEX_ATTRIBS fails · bb7740cc
    hendrikw authored Oct 20, 2015
    I'm not sure why yet, but when using angle in skia,
    getIntegerv(GL_MAX_VERTEX_ATTRIBS, &maxVertexAttribs) sometimes fails,
    and when that happens we attempt to allocate and array with the size of
    maxVertexAttribs, which is uninitialized, which could be huge.
    
    Prevent this by initializing the variable.
    
    Also sweep through other similar calls and ensure that these use
    initialized values (test code has not been updated)
    
    BUG=skia:4380
    
    Change-Id: If1f3cf72f2b2829ad3933637af8778d574a20f61
    Reviewed-on: https://chromium-review.googlesource.com/307239Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Tryjob-Request: Jamie Madill <jmadill@chromium.org>
    Tryjob-Request: Dian Xiang <dianx@google.com>
    Tested-by: 's avatarHendrik Wagenaar <hendrikw@chromium.org>
    bb7740cc
StencilOperations.cpp 7.68 KB
EditWeb IDE
×

Replace StencilOperations.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.