Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • compiler
  • translator
  • ValidateLimitations.cpp
Find file
BlameHistoryPermalink
  • Olli Etuaho's avatar
    Remove redundant index integer check from ValidateLimitations · 8e89866d
    Olli Etuaho authored Dec 11, 2015
    Non-integer indices are already rejected in the parser, so the
    ValidateLimitations pass doesn't need to check for them.
    
    ESSL 1.00 spec is not actually terribly clear about whether the
    parser should do this check, but the language grammar in the spec only
    has indexing with "integer_expression" so it seems like ANGLE's
    interpretation of only allowing indexing with integers is correct.
    ESSL 3.00 makes this restriction explicitly clear in section 5.7.
    
    BUG=angleproject:1254
    TEST=angle_unittests
    
    Change-Id: I02b2a6f4d9fa7801a98df63ed21bc990e1585eb8
    Reviewed-on: https://chromium-review.googlesource.com/317741Reviewed-by: 's avatarZhenyao Mo <zmo@chromium.org>
    Tested-by: 's avatarOlli Etuaho <oetuaho@nvidia.com>
    8e89866d
ValidateLimitations.cpp 13.9 KB
EditWeb IDE
×

Replace ValidateLimitations.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.