Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • gl_tests
  • GLSLTest.cpp
Find file
BlameHistoryPermalink
  • Olli Etuaho's avatar
    Fix ambiguous function call issues in HLSL output · be59c2fb
    Olli Etuaho authored Mar 07, 2016
    D3D compiler can't resolve between these overloaded functions:
    
    float4 vec4(float2x2 x0);
    float4 vec4(float4 x0);
    
    Include the parameter types in the function name to disambiguate
    between overloaded user-defined functions and constructors, like this:
    
    float4 vec4_float2x2(float2x2 x0);
    float4 vec4_float4(float4 x0);
    
    This is only done for float2x2 and float4 parameters, other parameter
    types like float2x3 vs. float3x2 don't need this.
    
    BUG=angleproject:1099
    BUG=angleproject:1030
    TEST=angle_end2end_tests,
         dEQP-GLES3.functional.attribute_location.* (10 more tests pass),
         dEQP-GLES2.functional.attribute_location.*
    
    Change-Id: Ief047d41b0adbc238393c3c13cb29771cbb83d58
    Reviewed-on: https://chromium-review.googlesource.com/329882Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
    Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
    be59c2fb
GLSLTest.cpp 47 KB
EditWeb IDE
×

Replace GLSLTest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.