Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • validationES3.cpp
Find file
BlameHistoryPermalink
  • Olli Etuaho's avatar
    Fix framebuffer attachment enum validation · 84c9f593
    Olli Etuaho authored Mar 09, 2016
    In GLES 3.0, GL_COLOR_ATTACHMENTi enums run all the way up to i=31,
    and don't stop at i=15 which the validation was previously checking
    against. It's acceptable to use this new enum range also for
    EXT_draw_buffers, since an error will still be generated if an enum
    is outside the range of maximum supported attachments.
    
    Also, generate INVALID_ENUM when dEQP tests expect it to be generated
    for color attachment number that's outside the supported range. This
    is not in line with the published 3.0 spec, but that's just an
    oversight in the spec document.
    
    Also fix incorrect INVALID_VALUE error in the validation of
    renderbufferStorageMultisample to INVALID_OPERATION.
    
    BUG=angleproject:1101
    TEST=dEQP-GLES3.functional.negative_api.buffer.* (all pass)
    
    Change-Id: Ib8cf92651d29ef8fe8da0ce4bfa456cbc4d48850
    Reviewed-on: https://chromium-review.googlesource.com/332140Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
    Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
    84c9f593
validationES3.cpp 74.3 KB
EditWeb IDE
×

Replace validationES3.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.