Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • compiler
  • translator
  • ShaderVars.cpp
Find file
BlameHistoryPermalink
  • Jamie Madill's avatar
    CollectVariables: Don't include block name in field name. · 39046169
    Jamie Madill authored Feb 08, 2016
    The spec mandates that the instance name of a block determines how the
    active uniform name for this field is reported. However, our handling
    of this was a bit bugged. We would include the proper prefix on the
    compiler-side, but this mangled the hashing, and was also not strictly
    needed. We now also expose the instance name, so we can determine the
    proper prefix for variable linking on the GL-side of things. This also
    is consistent with how we handle other spec issues, where the GL-side
    handles the GL-API specific functionality.
    
    This also allows us to fix name hashing of instanced uniform blocks,
    which was previously broken because we would hash the full name of the
    active uniform, instead of just the field.
    
    BUG=angleproject:1306
    
    Change-Id: I06ace6dbc3f75fdd8129677360dcc142aa89136e
    Reviewed-on: https://chromium-review.googlesource.com/326681Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
    Commit-Queue: Jamie Madill <jmadill@chromium.org>
    39046169
ShaderVars.cpp 10.1 KB
EditWeb IDE
×

Replace ShaderVars.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.