Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • compiler
  • translator
  • ParseContext.cpp
Find file
BlameHistoryPermalink
  • Olli Etuaho's avatar
    Names of built-in functions cannot be redeclared as functions · c4a96d67
    Olli Etuaho authored Jul 23, 2015
    With ESSL 3.00, names of built-in functions cannot be redeclared as
    functions, and therefore an error needs to be generated if a built-in
    function is overloaded.
    
    This is fixed by inserting unmangled built-ins into a special set in
    the symbol table and checking if function declarations match any of
    the built-ins in the set.
    
    The regular symbol table structures can't be used for storing the
    unmangled names because that interferes with name hashing in
    OutputGLSL.
    
    Credit goes to Arun Patole, apatole@nvidia.com for initially
    investigating this issue and developing the first version of the
    patch.
    
    BUG=angleproject:1066
    TEST=angle_unittests,
    dEQP-GLES3.functional.shaders.functions.invalid.overload_builtin_function*
    (2 tests started passing with this change)
    
    Change-Id: I28c8325f5a3a8f4a97226b0dfdbb9762724fa609
    Reviewed-on: https://chromium-review.googlesource.com/328994Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Commit-Queue: Jamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
    c4a96d67
ParseContext.cpp 140 KB
EditWeb IDE
×

Replace ParseContext.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.