Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • compiler
  • translator
  • Initialize.cpp
Find file
BlameHistoryPermalink
  • Jamie Madill's avatar
    translator: Fix use-after-free with DepthRange. · f07246f6
    Jamie Madill authored Jun 21, 2016
    Because this builtin uses a structure, certain shaders could trigger
    the mangled name to be allocated during normal shader compilation.
    Then when the scope is popped, the mangled name for DepthRange is
    freed, and we're left with a dangling pointer.
    
    Fix this temporarily by enforcing mangled name construction when
    we initialize the builtins, but we should look for a more robust and
    future-proof fix.
    
    BUG=620937
    
    Change-Id: If130c8b48a18054502abaec08f10264f282b4925
    Reviewed-on: https://chromium-review.googlesource.com/354494Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
    Reviewed-by: 's avatarAntoine Labour <piman@google.com>
    Commit-Queue: Jamie Madill <jmadill@chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/360480Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    f07246f6
Initialize.cpp 38.9 KB
EditWeb IDE
×

Replace Initialize.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.