Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • compiler
  • translator
  • PoolAlloc.cpp
Find file
BlameHistoryPermalink
  • Jamie Madill's avatar
    translator: Fix builtin function emulator use-after-free. · 392c3de4
    Jamie Madill authored Jun 17, 2016
    We were calling the global pool allocator in the builtin function
    emulator, which would lead to us freeing TTypes that were still
    referenced. Fix this by using the TCache which was designed for
    such a purpose, and locking the allocator around the builtin
    function emulator to try and prevent similar bugs from creeping
    in.
    
    Eventually we would like to get rid of the global allocator and
    replace it with different pools in different contexts, which are
    managed more safely.
    
    BUG=620937
    
    Change-Id: If501ff6ea4d9bf8a2b8f89f2c94a01386f79ee3a
    Reviewed-on: https://chromium-review.googlesource.com/353671Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
    Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
    Commit-Queue: Jamie Madill <jmadill@chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/360249Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    392c3de4
PoolAlloc.cpp 8.12 KB
EditWeb IDE
×

Replace PoolAlloc.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.