Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • validationES_unittest.cpp
Find file
BlameHistoryPermalink
  • Jamie Madill's avatar
    Context: Remove mutable gl::State getter. · dfde6abf
    Jamie Madill authored Jun 09, 2016
    This will preserve layering - the API layer doesn't mutate the state
    directly, it passes the API call through to the Context. Is also
    removes the possiblity of any shenanigans of the Validation layer
    changing the GL state.
    
    Also, this CL refactors a few validation entry points to take
    ValidationContext instead of Context. ValidationContext will be the
    correct way to interact with the gl::Context in the Validation code.
    
    Finally, additional refactorings make ContextState a proper class with
    private data. This allows the ContextState itself to keep a mutable
    pointer to the gl::State, so ValidationContext can modify it if
    necessary (and it will be necessary for Framebuffer completeness
    caching).
    
    BUG=angleproject:1388
    
    Change-Id: I86ab3561573caa9535c8d1b8aad4ab3d0e7cd470
    Reviewed-on: https://chromium-review.googlesource.com/348954Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
    Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
    Commit-Queue: Jamie Madill <jmadill@chromium.org>
    dfde6abf
validationES_unittest.cpp 5.17 KB
EditWeb IDE
×

Replace validationES_unittest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.