Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • compiler
  • translator
  • SplitSequenceOperator.cpp
Find file
BlameHistoryPermalink
  • Olli Etuaho's avatar
    Fix splitting nested sequence operators · ab481645
    Olli Etuaho authored Aug 26, 2016
    Make sure that only one sequence operator is split on one iteration
    of SplitSequenceOperator. This prevents multiple successive PostVisit
    calls to nested sequence operator nodes from adding duplicate nodes
    to the AST. The sequence operators are split starting from the
    outermost one to preserve execution order.
    
    Note that the shader translator somewhat unexpectedly generates nested
    sequence operators in the AST when there is a sequence operator with
    more than two operands, so this bug ended up affecting shaders in the
    wild. The code around parsing sequence operators could be clarified
    separately.
    
    BUG=638313
    TEST=angle_end2end_tests
    
    Change-Id: Ic6400a484ceff0c790c2290f7b4b80980f87cd88
    Reviewed-on: https://chromium-review.googlesource.com/376678Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
    ab481645
SplitSequenceOperator.cpp 5.45 KB
EditWeb IDE
×

Replace SplitSequenceOperator.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.