Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • compiler_tests
  • PruneEmptyDeclarations_test.cpp
Find file
BlameHistoryPermalink
  • Olli Etuaho's avatar
    Remove qualifiers from empty struct declarations in output · 474a08c0
    Olli Etuaho authored Jun 28, 2016
    Empty struct declarations with qualifiers are rejected by NVIDIA GL
    driver version 367.27. For example this kind of construct that is
    expected to be accepted by the WebGL conformance tests is rejected:
    
    const struct a {
        int i;
    };
    
    Since qualifiers do not carry meaning unless a struct declaration
    has declarators, they can be simply omitted from the translator
    output in this kind of cases to work around this driver issue.
    
    New unit test is added to check that pruning empty declarations works
    correctly.
    
    BUG=angleproject:1430
    BUG=622492
    TEST=WebGL conformance tests, angle_unittests
    
    Change-Id: Id83f83124ae597fcdfa15100d336c2c207d9449c
    Reviewed-on: https://chromium-review.googlesource.com/356362Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
    474a08c0
PruneEmptyDeclarations_test.cpp 1.47 KB
EditWeb IDE
×

Replace PruneEmptyDeclarations_test.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.