Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • formatutils.h
Find file
BlameHistoryPermalink
  • Geoff Lang's avatar
    Fix validation of ReadPixels format and type. · f607c60a
    Geoff Lang authored Sep 21, 2016
    The validation for ReadPixels allows for two combations of format/type:
      1. Based on the current framebuffer's component type.
        * GL_RGBA/GL_UNSIGNED_BYTE if the framebuffer is a normalized (signed
          or unsigned).
        * GL_RGBA_INTEGER/GL_INTEGER if the framebuffer is an
          integer format.
        * GL_RGBA_INTEGER/GL_UNSIGNED_INTEGER if the framebuffer is an
          unsigned integer format.
        * GL_RGBA/GL_FLOAT if the framebuffer is any type of float
          framebuffer (added in EXT_color_buffer_float).
        * These combations are detailed in the ES2 spec on pg 105 or ES3 on pg
          193.
      2. The implementation read format/type returned from glGetIntegerv.
        * These formats are added by specs, OES_texture_float, EXT_texture_rg,
          EXT_read_format_bgra, etc.
    
    Update the GL and D3D backends to perform the conversion from GL_HALF_FLOAT
    to GL_HALF_FLOAT_OES.
    
    Continue allowing reading as BGRA_EXT to support Skia.  Should be removed in
    the future.
    
    BUG=607283
    BUG=angleproject:1478
    
    Change-Id: I0312cad4d5f138ab036f383d221f8ccd19a77f6d
    Reviewed-on: https://chromium-review.googlesource.com/346232
    Commit-Queue: Geoff Lang <geofflang@chromium.org>
    Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
    f607c60a
formatutils.h 8.45 KB
EditWeb IDE
×

Replace formatutils.h

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.