Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • compiler_tests
  • MalformedShader_test.cpp
Find file
BlameHistoryPermalink
  • Olli Etuaho's avatar
    Fix folding shifts when operands have different signedness · 2cacb778
    Olli Etuaho authored Sep 26, 2016
    The code used to incorrectly assert that the right-hand side of shift
    should have the same signedness as the left-hand side. Instead simply
    assert that both the lhs and rhs are integer typed, and also don't
    rely on aliasing via union when accessing bit shift operands.
    
    Also disallow constant folded bit shifts where the right hand side is
    greater than 31. Shifting with values greater than the width of the
    type has undefined results in both ESSL and C++.
    
    BUG=chromium:648135
    TEST=angle_unittests
    
    Change-Id: I84a99abc55f0eeda549b4781e954d17ba7b87552
    Reviewed-on: https://chromium-review.googlesource.com/389351Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
    Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
    2cacb778
MalformedShader_test.cpp 77.4 KB
EditWeb IDE
×

Replace MalformedShader_test.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.