Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • compiler
  • translator
  • ParseContext.cpp
Find file
BlameHistoryPermalink
  • Olli Etuaho's avatar
    Disallow samplers as ternary operands · de318b26
    Olli Etuaho authored Oct 25, 2016
    Quoting the ESSL 1.00 spec section 4.1.7: "Except for parameters to
    texture lookup functions, array indexing, structure field selection,
    and parentheses, samplers are not allowed to be operands in
    expressions."
    
    ESSL 3.00 has a similar passage related to opaque types.
    
    Validate this correctly. Compatibility risk should be low, since
    attempting to use samplers in ternary operators was already failing
    before this in most cases.
    
    BUG=angleproject:1551
    TEST=angle_unittests
    
    Change-Id: I6cbb536f473ba9674d558b14a458f3799f9c7c9c
    Reviewed-on: https://chromium-review.googlesource.com/402694Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
    de318b26
ParseContext.cpp 152 KB
EditWeb IDE
×

Replace ParseContext.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.