Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • compiler
  • translator
  • IntermNode.cpp
Find file
BlameHistoryPermalink
  • Olli Etuaho's avatar
    Never add declarations without children to the AST · 8162926b
    Olli Etuaho authored Apr 19, 2017
    When block nodes were being created for loop bodies that didn't have
    braces in the parsed source, the code didn't check if the loop body
    was a declaration node without children. Always use appendStatement()
    for adding statements to a block, so that declaration nodes without
    children don't end up in the AST.
    
    Similarly make sure that loop init nodes aren't declarations without
    children.
    
    BUG=chromium:712550
    TEST=angle_end2end_tests
    
    Change-Id: I5e79b700fe6158fa2422fcf4cd13818b2bd24863
    Reviewed-on: https://chromium-review.googlesource.com/481660Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
    Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
    8162926b
IntermNode.cpp 123 KB
EditWeb IDE
×

Replace IntermNode.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.