Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • gl_tests
  • VertexAttributeTest.cpp
Find file
BlameHistoryPermalink
  • Shao's avatar
    Fix bug in updating vertex attribs with client memory pointers · 4181bc97
    Shao authored Mar 17, 2017
    In DEBUG version, when using OpenGL back-ends, ANGLE may meet an
    INVALID_OPERATION error from driver when attemping to update an
    attribute which is disabled and using a client memory pointer.
    
    This patch fixes this bug by skipping such vertex attributes when
    updating them to driver. With this patch the process to update
    vertex attributes should be:
    (1) For enabled attributes using client memory pointer:
        update by streaming mode in streamAttributes()
    (2) For disabled attributes using client memory pointer:
        just label them dirty and skip them
    (3) For attributes using buffer objects:
        update with vertexAttrib*Pointer
    
    BUG=angleproject:1942
    
    Change-Id: I57043e5904eb4a342fa22d449d98a957010170d6
    Reviewed-on: https://chromium-review.googlesource.com/456747
    Commit-Queue: Geoff Lang <geofflang@chromium.org>
    Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
    4181bc97
VertexAttributeTest.cpp 37.4 KB
EditWeb IDE
×

Replace VertexAttributeTest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.