Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • angle.gyp
Find file
BlameHistoryPermalink
  • Corentin Wallez's avatar
    Fix compilation of the Vulkan loader / layers in standalone · 6a1d2f93
    Corentin Wallez authored May 02, 2017
    This commit introduces a stamping mechanism to make sure the order of
    build dependencies is correct.
    
    In GYP there are the following build order dependencies (between others):
     - A target link depends on previous target links
     - A target source compile depends on that target actions outputs
     - An action output depends on the action inputs
    
    The problem was that there were actions in vulkan_layer_utils_static
    that generated headers needed by vulkan_loader's sources (between others)
    Making a "dependencies" relationship between the two was not enough to
    ensure the headers were generated before the source were compiled.
    
    Instead we replicated the "stamping" mechanism used in GN using GYP
    actions that depend on the headers and output a dummy stamp file. This
    completes the build order dependencies: the sources depend on the stamp
    which depend on the action's input, i.e. the generated headers.
    
    BUG=angleproject:1668
    
    Change-Id: I2de15ac2ea8f838acdbf43da1f111b28b8cc2184
    Reviewed-on: https://chromium-review.googlesource.com/493892
    Commit-Queue: Corentin Wallez <cwallez@chromium.org>
    Reviewed-by: 's avatarFrank Henigman <fjhenigman@chromium.org>
    6a1d2f93
angle.gyp 15.2 KB
EditWeb IDE
×

Replace angle.gyp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.