Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • renderer
  • d3d
  • VertexDataManager.cpp
Find file
BlameHistoryPermalink
  • Jiawei-Shao's avatar
    Initialize currentValueAttrib->binding in updateCurrentValueAttribs · 995c2ed2
    Jiawei-Shao authored May 15, 2017
    This patch intends to fix a crash issue in the win-clang build of
    ANGLE by adding the missing currentValueAttrib->binding assignment
    in StateManager11.cpp::updateCurrentValueAttribs(). In D3D11 all
    vertex attributes (VertexAttribute and its VertexBinding) should be
    treated as a whole, so we should always ensure these two parts are
    availabe.
    
    This patch also add ASSERTs before using *translated->attrib and
    *translated->binding to prevent a TranslatedAttribute object
    having a null attrib or binding.
    
    BUG=chromium:721783, angleproject:1593
    
    Change-Id: Id11d6f1d4c37daabad2265e01ea38eb51046b9cb
    Reviewed-on: https://chromium-review.googlesource.com/505928Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
    Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
    Commit-Queue: Corentin Wallez <cwallez@chromium.org>
    995c2ed2
VertexDataManager.cpp 20 KB
EditWeb IDE
×

Replace VertexDataManager.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.