Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • gl_tests
  • GLSLTest.cpp
Find file
BlameHistoryPermalink
  • Olli Etuaho's avatar
    Fix parsing GLSL loop conditions that declare a variable · 914b79a6
    Olli Etuaho authored Jun 19, 2017
    Now the variable declaration is included in the AST, so that the loop
    body may refer to the variable. The variable declaration is placed in
    a block that wraps the loop. This way we can still only have
    TIntermTyped loop conditions in the AST, which keeps the code dealing
    with loops fairly simple and type safe.
    
    This change includes reversing the return value of executeInitializer,
    so that it returns true on success and false on error. This is more in
    line with other ParseContext member functions.
    
    BUG=angleproject:2073
    TEST=angle_end2end_tests
    
    Change-Id: I5c4ecbf1b438d3fff6d6237c0dcf191e2a19664c
    Reviewed-on: https://chromium-review.googlesource.com/539639Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
    914b79a6
GLSLTest.cpp 98.3 KB
EditWeb IDE
×

Replace GLSLTest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.