Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • formatutils.h
Find file
BlameHistoryPermalink
  • Yuly Novikov's avatar
    Revert "Don't expose non-conformant multisampling modes on GL" · c8a8b843
    Yuly Novikov authored Jun 28, 2017
    This reverts commit 3cd0dd37.
    
    Reason for revert: crashes on NVIDIA Shield TV
    https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28NVIDIA%20Shield%20TV%29/builds/1816
    
    Original change's description:
    > Don't expose non-conformant multisampling modes on GL
    > 
    > Some NVIDIA GL drivers expose non-conformant multisampling modes. The
    > conformance of multisampling modes can be queried using the extension
    > NV_internalformat_sample_query. Use it to filter out the
    > non-conformant modes from the modes that are exposed by ANGLE.
    > 
    > The MAX_SAMPLES value and other similar values stored in caps also
    > need to be lowered to match the maximum number of samples exposed
    > for required formats.
    > 
    > There seems to be an NVIDIA driver bug related to querying
    > STENCIL_INDEX8 multisample format. Work around this by querying
    > DEPTH24_STENCIL8 instead.
    > 
    > There's also some confusion around whether RGB9_E5 should be
    > renderable. Once the floating point texture extensions got rolled
    > into the core GL spec, it was eventually made clear that RGB9_E5
    > is intended not to be renderable. The extension specs that predate
    > float textures in the core spec do suggest that it would be
    > renderable, but in practice drivers that advertise the extension
    > strings don't reliably implement RGB9_E5 as renderable. Solve this
    > by disabling it as a renderable format and adding an explanatory
    > comment.
    > 
    > BUG=chromium:682815
    > TEST=angle_end2end_tests,
    >      dEQP-GLES31.functional.state_query.internal_format.renderbuffer.*
    > 
    > Change-Id: I2218e3a23ea7b48a0615fea77a91897dc7d5fe9e
    > Reviewed-on: https://chromium-review.googlesource.com/525515
    > Reviewed-by: Geoff Lang <geofflang@chromium.org>
    > Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
    
    TBR=geofflang@chromium.org,jmadill@chromium.org,cwallez@chromium.org,oetuaho@nvidia.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: chromium:682815
    Change-Id: I1ebdf52c3fab1526f5a561ac4c8555e305ef2243
    Reviewed-on: https://chromium-review.googlesource.com/551164Reviewed-by: 's avatarYuly Novikov <ynovikov@chromium.org>
    Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
    c8a8b843
formatutils.h 9.32 KB
EditWeb IDE
×

Replace formatutils.h

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.