Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • formatutils.h
Find file
BlameHistoryPermalink
  • Corentin Wallez's avatar
    Revert "Fix BlitFramebuffer validation for BGRA sources and targets." · 26cf35a8
    Corentin Wallez authored Jul 26, 2017
    This reverts commit 17d27031.
    
    Reason for revert:
     - New test fails on NVIDIA and AMD on Windows when using the backbuffer FAST_PATH.
     - SetUp code ASSERT_GL_NO_ERROR (line 269) but a GL error happens on all Windows and Linux Intel OpenGL.
    
    Original change's description:
    > Fix BlitFramebuffer validation for BGRA sources and targets.
    > 
    > It is legal to blit between GL_RGBA8 and GL_BGRA8 sources and
    > destinations when resolving multisampled renderbuffers. Expand
    > BlitFramebuffer's validation to handle this case.
    > 
    > Work around a bug in macOS' OpenGL driver querying the number of
    > samples for GL_BGRA8.
    > 
    > Query GL_MAX_VERTEX_OUTPUT_COMPONENTS on the Core Profile to work
    > around an error generated on macOS when querying
    > GL_MAX_VARYING_COMPONENTS.
    > 
    > Expand the BlitFramebuffer tests to cover these cases and start
    > running them on the OpenGL backend.
    > 
    > BUG=angleproject:891
    > 
    > Change-Id: I4829585d2b6428ce0bc7509c4734d33709a0930b
    > Reviewed-on: https://chromium-review.googlesource.com/582268
    > Commit-Queue: Geoff Lang <geofflang@chromium.org>
    > Reviewed-by: Kenneth Russell <kbr@chromium.org>
    > Reviewed-by: Geoff Lang <geofflang@chromium.org>
    
    TBR=geofflang@chromium.org,kbr@chromium.org
    
    Change-Id: I220bc482194cf7fad5e7e732a6d043ce0d504d79
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: angleproject:891
    Reviewed-on: https://chromium-review.googlesource.com/586428Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
    Commit-Queue: Corentin Wallez <cwallez@chromium.org>
    26cf35a8
formatutils.h 9.73 KB
EditWeb IDE
×

Replace formatutils.h

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.