Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • renderer
  • gl
  • FunctionsGL.h
Find file
BlameHistoryPermalink
  • Olli Etuaho's avatar
    Re-land: Don't expose non-conformant multisampling modes on GL · 50c562de
    Olli Etuaho authored Jun 06, 2017
    Re-landing with a fallback for failed internal format queries to work
    around issue seen on Shield TV. Also fixed wrong handling of integer
    RG formats in isRequiredRenderbufferFormat.
    
    Some NVIDIA GL drivers expose non-conformant multisampling modes. The
    conformance of multisampling modes can be queried using the extension
    NV_internalformat_sample_query. Use it to filter out the
    non-conformant modes from the modes that are exposed by ANGLE.
    
    The MAX_SAMPLES value and other similar values stored in caps also
    need to be lowered to match the maximum number of samples exposed
    for required formats.
    
    There seems to be an NVIDIA driver bug related to querying
    STENCIL_INDEX8 multisample format. Work around this by querying
    DEPTH24_STENCIL8 instead.
    
    There's also some confusion around whether RGB9_E5 should be
    renderable. Once the floating point texture extensions got rolled
    into the core GL spec, it was eventually made clear that RGB9_E5
    is intended not to be renderable. The extension specs that predate
    float textures in the core spec do suggest that it would be
    renderable, but in practice drivers that advertise the extension
    strings don't reliably implement RGB9_E5 as renderable. Solve this
    by disabling it as a renderable format and adding an explanatory
    comment.
    
    BUG=chromium:682815
    TEST=angle_end2end_tests,
         dEQP-GLES31.functional.state_query.internal_format.renderbuffer.*
    
    Change-Id: I727f03045a1534d6764b571e6d839243705d25b3
    Reviewed-on: https://chromium-review.googlesource.com/551957Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Commit-Queue: Jamie Madill <jmadill@chromium.org>
    50c562de
FunctionsGL.h 35.8 KB
EditWeb IDE
×

Replace FunctionsGL.h

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.