Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • Texture.cpp
Find file
BlameHistoryPermalink
  • JiangYizhou's avatar
    ES31: Fix bug on incomplete texture validation of internalformat and filterable · 0f2aa31d
    JiangYizhou authored Jul 10, 2017
    Multisampled texture with unfilterable internalformat and default filter state shouldn't
    be justified as incomplete texture in angle. However, the default filter state is set to
    LINEAR and internalformat like R8I or R8UI is not filterable, which lead to texture
    incomplete.
    
    In es 3.1 spec 8.16, 'The effective internal format specified for the texture arrays is a
    sized internal color format that is not texture - filterable(see table 8.13), and either
    the magnification filter is not NEAREST or the minification filter is neither NEAREST nor
    NEAREST_MIPMAP_NEAREST'.
    
    As to Table 20.11, The default value of minFilter is NEAREST_MIPMAP_LINEAR, magFilter is LINEAR.
    
    Because in 11.1.3.3,'Multisample textures are not filtered when samples are fetched, and filter
    state is ignored.' So we ignore filtering for multismaple texture completeness.
    
    BUG=angleproject:1590
    TEST=dEQP-GLES31.functional.shaders.builtin_functions.texture_size.samples_*_texture_2d
    TEST=dEQP-GLES31.functional.shaders.builtin_functions.texture_size.samples_*_texture_int_2d
    TEST=dEQP-GLES31.functional.shaders.builtin_functions.texture_size.samples_*_texture_uint_2d
    TEST=dEQP-GLES31.functional.texture.multisample.samples_*.use_texture_color_2d
    TEST=dEQP-GLES31.functional.texture.multisample.samples_*.use_texture_int_2d
    TEST=dEQP-GLES31.functional.texture.multisample.samples_*.use_texture_uint_2d
    TEST=dEQP-GLES31.functional.texture.multisample.samples_*.use_texture_depth_2d
    
    Change-Id: I0533bd028e0bbb66d9f731a2395f6c8ae7db8938
    Reviewed-on: https://chromium-review.googlesource.com/564843
    Commit-Queue: Geoff Lang <geofflang@chromium.org>
    Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
    0f2aa31d
Texture.cpp 38.9 KB
EditWeb IDE
×

Replace Texture.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.