Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • compiler
  • translator
  • RemoveSwitchFallThrough.cpp
Find file
BlameHistoryPermalink
  • Olli Etuaho's avatar
    Recognize more non-fallthrough cases in switch/case · 4bd730c8
    Olli Etuaho authored Oct 10, 2017
    RemoveSwitchFallThrough now treats cases where break; or return; is
    nested inside a block as non-fallthrough to avoid unnecessary
    duplication of code. For example, the case 1 below would previously
    get treated as fall-through:
    
    switch(foo)
    {
        case 1:
        {
            break;
        }
        default:
            break;
    }
    
    Now RemoveSwitchFallThrough doesn't do anything to this code.
    
    BUG=chromium:772695
    TEST=angle_end2end_tests
    
    Change-Id: Iafab6d8b05c63bcdb5f54834dbc1f41192c31dd4
    Reviewed-on: https://chromium-review.googlesource.com/709197Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
    4bd730c8
RemoveSwitchFallThrough.cpp 8.19 KB
EditWeb IDE
×

Replace RemoveSwitchFallThrough.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.