Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • compiler
  • preprocessor
  • ExpressionParser.y
Find file
BlameHistoryPermalink
  • Olli Etuaho's avatar
    Fix signed integer overflow in GLSL preprocessor left shift · a3d384ad
    Olli Etuaho authored Oct 06, 2017
    Signed integer overflow is undefined in C++, whereas unsigned integer
    overflow is not. Always cast left shift operand to unsigned to avoid
    UB.
    
    On common compilers, the behavior was already the same before this
    patch, so this patch is done mostly for the benefit of automated fuzz
    testing.
    
    BUG=chromium:743136
    TEST=angle_unittests
    
    Change-Id: I7aab939036bb19a37f258cef4297b560da3cd9d5
    Reviewed-on: https://chromium-review.googlesource.com/704659Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
    a3d384ad
ExpressionParser.y 12.2 KB
EditWeb IDE
×

Replace ExpressionParser.y

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.