Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • renderer
  • d3d
  • ShaderD3D.cpp
Find file
BlameHistoryPermalink
  • Olli Etuaho's avatar
    Start D3D constant register allocations from 1 on NVIDIA · d8724a94
    Olli Etuaho authored Dec 29, 2017
    Recent NVIDIA drivers have a bug where a specific optimized path
    inside the driver doesn't handle constant register 0 correctly. Work
    around this by starting constant register allocations from 1. This
    should make sure that the bug doesn't trigger if the ordering of
    uniforms is changed on the D3D backend.
    
    The repro case seems to require some specific driver state to be set
    that's used inside Chromium. Because of this we have not been able to
    develop a standalone test case so far.
    
    The maximum number of available uniform slots is reduced accordingly.
    This should not take them below required minimums in the spec.
    
    BUG=angleproject:2294
    TEST=WebGL tests on passthrough command buffer,
         angle_end2end_tests --gtest_filter=*GLSLTest*Uniform*
    
    Change-Id: I92fff71efe5432ea7f15a7e90d497492514c65dc
    Reviewed-on: https://chromium-review.googlesource.com/847481
    Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
    Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    d8724a94
ShaderD3D.cpp 7.93 KB
EditWeb IDE
×

Replace ShaderD3D.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.