Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • third_party
  • glslang
  • BUILD.gn
Find file
BlameHistoryPermalink
  • Jamie Madill's avatar
    Revert "Vulkan: Add glslang validator to build." · 26403533
    Jamie Madill authored Feb 14, 2018
    This reverts commit 560bfbcb.
    
    Reason for revert:
    
    Appears to be causing a compile error on the ANGLE roll.
    https://chromium-review.googlesource.com/c/chromium/src/+/914429
    https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_compile_dbg_ng/11598
    
    /b/swarming/w/ir/cache/builder/linux/src/out/Debug/../../third_party/llvm-build/Release+Asserts/bin/ld.lld: error: undefined symbol: std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::compare(unsigned long, unsigned long, char const*) const
    >>> referenced by StandAlone.cpp
    
    Original change's description:
    > Vulkan: Add glslang validator to build.
    > 
    > This binary will be used to generate internal shaders for
    > clearing/blit/etc.
    > 
    > Bug: angleproject:2339
    > Change-Id: I13db7d7a4f5a0155798c9b9a6d2972dd69a680ef
    > Reviewed-on: https://chromium-review.googlesource.com/904683
    > Commit-Queue: Jamie Madill <jmadill@chromium.org>
    > Reviewed-by: Geoff Lang <geofflang@chromium.org>
    
    TBR=ynovikov@chromium.org,geofflang@chromium.org,jmadill@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: angleproject:2339
    Change-Id: I7bcedf27831648d4c659294d12cab50f6ef9f33f
    Reviewed-on: https://chromium-review.googlesource.com/919141Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarLuc Ferron <lucferron@chromium.org>
    Commit-Queue: Jamie Madill <jmadill@chromium.org>
    26403533
BUILD.gn 4.98 KB
EditWeb IDE
×

Replace BUILD.gn

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.