Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • VaryingPacking.cpp
Find file
BlameHistoryPermalink
  • Jamie Madill's avatar
    D3D9: Improve varying packing failure mode. · 61d5325e
    Jamie Madill authored Jan 31, 2018
    D3D9 has a special limitation on varying packing, where each
    variable takes up a full register width, and cannot share space
    with other packed varyings.
    
    A bug was counting registers incorrectly on D3D9. Fix this by
    introducing a new limitation exposed to the ANGLE front-end via
    the gl::Limitations structure. Now varying packing will fail
    correctly in the ANGLE linking front-end with a more descriptive
    error message, as such:
    
    "Could not pack varying blah"
    "Note: Additional non-conformant packing restrictions are enforced on D3D9."
    
    Also change the packing so that input built-in variables are
    counted towards varying limits (e.g. gl_PointSize), except for
    gl_Position. On D3D9 we don't pack gl_PointSize, since it is
    used in a special extra PSIZE register.
    
    Also update some tests to be more robust.
    
    Bug: chromium:804799
    Change-Id: I9027266a8b66a28626f038f259bff42ebf09dcd2
    Reviewed-on: https://chromium-review.googlesource.com/889898
    Commit-Queue: Jamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
    61d5325e
VaryingPacking.cpp 15.6 KB
EditWeb IDE
×

Replace VaryingPacking.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.