Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • State.cpp
Find file
BlameHistoryPermalink
  • Jamie Madill's avatar
    Refactor signal utils into Observer pattern. · d444255a
    Jamie Madill authored Feb 27, 2018
    These types were over-generalized. All use cases featured
    arrays of resources attached to single parent resources. The
    channel ID is sufficient to identify the child resource in the
    parent, and having variadic template arguments wasn't necessary.
    
    Futhermore we can rename these types to use the common Observer
    pattern. This should make them more readable to new developers.
    
    Also update some classes to inherit from Subject instead of
    having a member Subject. This cleans up the code in a few places.
    
    This should lead to a simpler refactor to allow dependent dirty
    bits notifications in the Vulkan back-end.
    
    In the following patch the signal_utils files will be renamed. They
    are not renamed in this patch to ensure git history is preserved.
    
    Bug: angleproject:2372
    Change-Id: I17a3f2c8d92afd4bb3cba2d378c3a2e8a6d7fb11
    Reviewed-on: https://chromium-review.googlesource.com/936690Reviewed-by: 's avatarLuc Ferron <lucferron@chromium.org>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Commit-Queue: Jamie Madill <jmadill@chromium.org>
    d444255a
State.cpp 76.5 KB
EditWeb IDE
×

Replace State.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.