Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • perf_tests
  • EGLInitializePerf.cpp
Find file
BlameHistoryPermalink
  • Frank Henigman's avatar
    Inherit privately from angle::NonCopyable. · aa7203ef
    Frank Henigman authored May 03, 2017
    Make all inheritance from angle::NonCopyable private so the compiler
    complains about this (admittedly unlikely) code:
    
      class Foo: angle::NonCopyable {
          virtual ~Foo() { ... }
      };
      angle::NonCopyable *p = new Foo;
      delete p;
    
    In the above code ~Foo() is not called, only ~NonCopyable(), because the
    latter is not virtual.  Making it virtual would add overhead to all derived
    classes which don't already have a virtual method.
    
    Also tighten access in NonCopyable, because we can.
    
    BUG=angleproject:2026
    
    Change-Id: Id0dc4d959cfb7bb82cf49382118129abb1d3a4f0
    Reviewed-on: https://chromium-review.googlesource.com/495352Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
    Commit-Queue: Frank Henigman <fjhenigman@chromium.org>
    aa7203ef
EGLInitializePerf.cpp 5.06 KB
EditWeb IDE
×

Replace EGLInitializePerf.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.