Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • renderer
  • vulkan
  • vk_helpers.cpp
Find file
BlameHistoryPermalink
  • Luc Ferron's avatar
    Vulkan: Bugfix in TextureVk::setSubImage and DynamicBuffer · 33e05bab
    Luc Ferron authored Apr 23, 2018
    Bug 1) The offset wasn't plumbed through for setSubImage.
    Bug 2) The DynamicBuffer allocation sometime allocates a bit more
    than requested, but we were using the size requested as the next offset
    instead of the actual allocated size. This could get us in a situation
    in certain corner cases where the next allocation would be done on the
    said buffer instead of using a new allocation as it should.
    
    Also enables a bunch of new texture_specification_* tests that were
    unable to run successfully without these 2 bug fixes.
    
    Found a weird issue on WIN AMD only and suppressed these tests for now.
    Will investigate part of the same bug number as a separate change.
    
    Bug: angleproject:2495
    Bug: angleproject:2492
    
    Change-Id: I490b1bf2d1795b7a1033365e29eac12a8bc50bff
    Reviewed-on: https://chromium-review.googlesource.com/1024380Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
    Commit-Queue: Luc Ferron <lucferron@chromium.org>
    33e05bab
vk_helpers.cpp 30 KB
EditWeb IDE
×

Replace vk_helpers.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.