Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • HandleAllocator.cpp
Find file
BlameHistoryPermalink
  • Nico Weber's avatar
    Fix MSan report in HandleAllocatorTest.Reallocation · b33972d4
    Nico Weber authored Mar 30, 2018
    [ RUN      ] HandleAllocatorTest.Reallocation
    ==30439==WARNING: MemorySanitizer: use-of-uninitialized-value
        #0 0x1a11ef5 in gl::HandleAllocator::allocate() third_party/angle/src/libANGLE/HandleAllocator.cpp:83:9
        #1 0x6643eb in (anonymous namespace)::HandleAllocatorTest_Reallocation_Test::TestBody() third_party/angle/src/libANGLE/HandleAllocator_unittest.cpp:75:42
    
    Looks like a true positive, one of the ctors wasn't initializing a
    field.
    
    Change-Id: Id8a93fe6c9a6f1f01249235630981f4f0ac4a782
    Reviewed-on: https://chromium-review.googlesource.com/987474
    Commit-Queue: Jamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    b33972d4
HandleAllocator.cpp 4.27 KB
EditWeb IDE
×

Replace HandleAllocator.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.