Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • Renderbuffer.h
Find file
BlameHistoryPermalink
  • Yuly Novikov's avatar
    Fix EGLImage pixel format validation · 2eb54074
    Yuly Novikov authored Aug 22, 2018
    This fixes the scenario when EGLImage source and target have different types.
    For example, a texture is created with unsigned format using glTexImage2D,
    it is used as a source of EGLImage with eglCreateImageKHR,
    and then the EGLImage is used to create a renderbuffer target with
    glEGLImageTargetRenderbufferStorageOES.
    
    OES_EGL_image doesn't specify what should happen in this case,
    but GL implementations (Nexus 5X) seem to allow using this renderbuffer in
    glFramebufferRenderbuffer and the resulting framebuffer is complete.
    Thus, in this case, instead of checking whether the renderbuffer format
    can be used in glFramebufferRenderbuffer, we need to check whether the
    original texture can be used in glFramebufferTexture2D.
    Similarly in reverse direction.
    
    Also, for the case of source renderbuffer and target texture,
    presume that glEGLImageTargetTexture2DOES will succeed regardless of
    renderbuffer format.
    
    1. Add isRenderable and isTexturable checks to egl::Image class,
       and perform different checks depending on source type.
    2. Add isRenderable check to FramebufferAttachment and delegate EGLImage
       attachments check to egl::Image.
    3. Use these checks in validation of EGLImageTargetTexture2D,
       EGLImageTargetRenderbufferStorage and when checking attachment completeness
    
    Bug: angleproject:2567
    
    Change-Id: I8e9f4a2930a4075a4d8464f62582c6825270187e
    Reviewed-on: https://chromium-review.googlesource.com/1192585
    Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
    Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
    2eb54074
Renderbuffer.h 3.75 KB
EditWeb IDE
×

Replace Renderbuffer.h

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.