Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • gl_tests
  • VertexAttributeTest.cpp
Find file
BlameHistoryPermalink
  • Qin Jiajia's avatar
    Fix the regression bug for ComputeBoids · fcf10b62
    Qin Jiajia authored Sep 19, 2018
    The old implementation missed considering compute program would also enter
    into applyActiveAttribLocationsMask. However, there was no bindVertexArray
    before updateAttribEnabled which resulted the previous VAO state was modified
    in unknown. And that's why ComputeBoids example wouldn't work correctly.
    
    This change adds a checking to not enter propagateProgramToVAO if it's a
    compute program since compute shader doesn't have vertex attributes. And
    an ASSERT is added to make sure that the right VAO is bound when
    updateAttribEnabled is called in applyActiveAttribLocationsMask.
    
    Bug: angleproject:2810
    
    Change-Id: I6e77853498a527ef3b755bbb1da5826a9134b164
    Reviewed-on: https://chromium-review.googlesource.com/c/1226227Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org>
    Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>
    fcf10b62
VertexAttributeTest.cpp 70.3 KB
EditWeb IDE
×

Replace VertexAttributeTest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.