Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • test_utils
  • ShaderCompileTreeTest.h
Find file
BlameHistoryPermalink
  • Martin Radev's avatar
    Populate gl_InstanceID attribute information explicitly · 115fc55e
    Martin Radev authored Jul 05, 2017
    While compiling ESSL1 shaders, with the compiler having both
    SH_INITIALIZE_BUILTINS_FOR_INSTANCED_MULTIVIEW and SH_VARIABLES
    set, variable collection terminates with an assertion failure. The reason
    behind this is that SH_INITIALIZE_BUILTINS_FOR_INSTANCED_MULTIVIEW
    adds gl_InstanceID to the AST to initialize the multiview builtins, but
    the variable collection pass cannot find gl_InstanceID information in
    the symbol table because the builtin is only available in ESSL 3.00 and
    greater.
    
    To address this the patch populates the gl_InstanceID attribute
    information explicitly in the variable collection pass instead of
    retrieving it from the symbol table.
    
    BUG=angleproject:2062
    TEST=angle_unittests
    
    Change-Id: I5ecb9967ebe6658e956d17a2637090f9b685ef33
    Reviewed-on: https://chromium-review.googlesource.com/559669Reviewed-by: 's avatarOlli Etuaho <oetuaho@nvidia.com>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
    115fc55e
ShaderCompileTreeTest.h 1.62 KB
EditWeb IDE
×

Replace ShaderCompileTreeTest.h

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.