Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • compiler_tests
  • GeometryShader_test.cpp
Find file
BlameHistoryPermalink
  • Jiawei Shao's avatar
    ES31: Add shader version check for CS and GS · e41df655
    Jiawei Shao authored Feb 09, 2018
    This patch adds the missing check on the shader version for compute
    and geometry shaders, which can fix a bug that ANGLE GLSL compiler
    doesn't report a compile error when compiling an empty compute or
    geometry shader in version 100 or 300.
    
    This patch also updates the original compiler tests on the check of
    shader version. In these tests, the compile errors are all caused by
    illegal layouts instead of shader versions, which is against the
    purpose of the tests.
    
    This patch also fixes an incorrect case that used an empty compute
    shader in version 300.
    
    BUG=angleproject:1442, angleproject:1941
    TEST=angle_unittests
    
    Change-Id: Ic26bb8eb312dbc0cec6a879997d0ae7a2e625a0f
    Reviewed-on: https://chromium-review.googlesource.com/910715
    Commit-Queue: Geoff Lang <geofflang@chromium.org>
    Reviewed-by: 's avatarOlli Etuaho <oetuaho@nvidia.com>
    Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
    Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
    e41df655
GeometryShader_test.cpp 48.9 KB
EditWeb IDE
×

Replace GeometryShader_test.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.