Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • gl_tests
  • VulkanUniformUpdatesTest.cpp
Find file
BlameHistoryPermalink
  • Jamie Madill's avatar
    Vulkan: Fix deleting in-use descriptor sets. · 78bcd2be
    Jamie Madill authored Oct 16, 2018
    Sequences of many frames with uniform updates could lead to a bug where
    we attempt to delete descriptor sets that are still in use. To trigger
    the bug we need to write enough uniform data to trigger a descriptor
    set to be freed. This would correctly trigger refresh sets in the
    Program. But if there was a second program idle in the background that
    also allocated descriptors from the old pool, the bug would manifest.
    
    Fix this by storing a shared handle to the descriptor pool in the
    Program. The dynamic descriptor pool won't recycle descriptor pools
    internally unless there are zero outstanding references to the pool.
    
    We could also improve this in a resource sharing situation by keeping
    a single shared dynamic descriptor pool per share group.
    
    Includes a contribution from tobine@google.com that adds a test to
    cover the bug.
    
    Bug: angleproject:2863
    Change-Id: Id585b85f33f8cfa3772ceff3af512d1e4fb0b75a
    Reviewed-on: https://chromium-review.googlesource.com/c/1271919Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Commit-Queue: Jamie Madill <jmadill@chromium.org>
    78bcd2be
VulkanUniformUpdatesTest.cpp 10.4 KB
EditWeb IDE
×

Replace VulkanUniformUpdatesTest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.