Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • HandleAllocator.h
Find file
BlameHistoryPermalink
  • Jamie Madill's avatar
    HandleAllocator: Fix heap ordering using std::greater. · fc3463da
    Jamie Madill authored Jan 03, 2018
    The default heap ordering is to return the greatest element in the
    heap. Since the handle allocator expects a minimal return value on
    a new allocation, this caused a bug. The bug is triggered by reserving
    handles, allocating new handles, then freeing the handles and
    allocating again with the same allocator. Fix the bug by using
    std::greater instead of std::less, which will make the heap
    return the smallest value instead of largest.
    
    Also adds some logging debugging code for the handle allocators.
    
    Bug: angleproject:1458
    Change-Id: Ibef5dcbed0a664ccad0e0335f081e2355162584b
    Reviewed-on: https://chromium-review.googlesource.com/848644
    Commit-Queue: Jamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarFrank Henigman <fjhenigman@chromium.org>
    fc3463da
HandleAllocator.h 1.55 KB
EditWeb IDE
×

Replace HandleAllocator.h

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.