Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • gl_tests
  • BindUniformLocationTest.cpp
Find file
BlameHistoryPermalink
  • Olli Etuaho's avatar
    Refactor CompileProgram utility · 624fbdcf
    Olli Etuaho authored Oct 01, 2018
    Tests often need to call gl functions to set up program related state
    after glCreateProgram has been called but prior to glLinkProgram is
    called. Add a callback function to the CompileProgram utility function
    to fulfill this need. This reduces code duplication considerably in
    several tests.
    
    An alternative way to improve CompileProgram would be to split it into
    several different utility functions. This might be slightly easier to
    read, but would also be a larger refactoring and require more checks
    at the call site.
    
    This will make it easier to implement EXT_blend_func_extended tests,
    which need to bind fragment outputs to different slots.
    
    BUG=angleproject:1085
    TEST=angle_end2end_tests
    
    Change-Id: I3ac8b7bdc21c6a1f14517bc7df0cf6f35abd7612
    Reviewed-on: https://chromium-review.googlesource.com/1254062
    Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
    Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
    624fbdcf
BindUniformLocationTest.cpp 18.8 KB
EditWeb IDE
×

Replace BindUniformLocationTest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.