Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • gl_tests
  • PointSpritesTest.cpp
Find file
BlameHistoryPermalink
  • Yuly Novikov's avatar
    Fix several of PointSpritesTest · 9c0e3063
    Yuly Novikov authored Apr 23, 2018
    PointWithoutAttributesCompliance,
    PointCoordRegressionTest,
    PointSpriteAlternatingDrawTypes
    were failing on Nexus 5X Vulkan, because pointSizeRange is [1,1] there,
    and the tests assume they can use point sizes larger than 1.
    
    Fix the tests to check whether the point size they want to use is available.
    
    Note: PointWithoutAttributesCompliance and PointSpriteAlternatingDrawTypes
    can actually work with size 1, though they need to calculate center
    pixel more accurately. However, looks like there is a bug in Nexus 5X
    driver, and no pixels are rendered. The tests do pass on Pixel 2.
    
    Bug: angleproject:2447
    Change-Id: I511574b1b11f2516c10209b85f86b3e7052e6686
    Reviewed-on: https://chromium-review.googlesource.com/1026979
    Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    9c0e3063
PointSpritesTest.cpp 18.6 KB
EditWeb IDE
×

Replace PointSpritesTest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.